RFR: 8140611: aarch64: jtreg test jdk/tools/pack200/UnpackerMemoryTest.java SEGVs

[Andrew Dinn]

On 27/10/15 18:20, Edward Nevill wrote:
> Please review the following webrev
> 
> http://cr.openjdk.java.net/~enevill/8140611/webrev/
> 
> JIRA Issue: https://bugs.openjdk.java.net/browse/JDK-8140611
> 
> Summary: The UnpackerMemoryTest SEGVs in jni_GetStringUTFChars.
> 
> The problem is that c_rarg3 is a really bad choice for a tmp register
> since at this point the native arguments have been loaded into
> registers. (I confess guilt for this).
> 
> 'lr' is a much better choice for the tmp register. We know this is
> free because we are just about to do a 'rt_call' which clobbers lr in
> any case.

Looks ok to me.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Matt Parson (USA), Charlie Peters
(USA), Michael O'Neill (Ireland)