[9] RFR 8139385: [TESTBUG]: JVMCI test crashes in constantPoolHandle::constantPoolHandle

Igor Ignatyev igor.ignatyev at oracle.com
Thu Oct 29 18:28:58 UTC 2015


Hi Konstantin,

the fix looks good to me.

Thanks,
— Igor
> On Oct 29, 2015, at 7:13 PM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
> 
> Hello
> 
> Please review a test bug fix in whitebox.cpp.
> 
> The problem with the test (crash) happened because of C++ type "long" on Windows 64-bit platforms has length of 32-bit, and when we casted a 64-bit pointer to "long" we had wrong pointer as a result.
> 
> The solution is to cast the pointer to "jlong", which is "signed long long" and is always 64-bit.
> 
> Tested by test "compiler/jvmci/compilerToVM/GetConstantPoolTest.java "
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8139385
> Webrev: http://cr.openjdk.java.net/~kshefov/8139385/webrev/
> 
> Thanks
> -Konstantin



More information about the hotspot-compiler-dev mailing list