RFR (S): JDK-8141042: Typos and refactoring in Compiler constraints functions

[Zoltán Majó]

The new webrev looks good to me!

Thank you and best regards,


Zoltan


On 10/30/2015 06:06 PM, Dmitry Dmitriev wrote:
> Hi Zoltan,
>
> Thank you for the review!
> I add spaces to the 243 and 244 lines in 
> commandLineFlagConstraintsCompiler.cpp. Also, by the way, I move '&&' 
> from start of the line 240 to the end of the line 239.
>
> webrev.01: http://cr.openjdk.java.net/~ddmitriev/8141042/webrev.01/ 
> <http://cr.openjdk.java.net/%7Eddmitriev/8141042/webrev.01/>
>
> Dmitry
>
> On 30.10.2015 19:50, Zoltán Majó wrote:
>> Hi Dmitry,
>>
>>
>> maybe you want to add a whitespace before opening a parenthesis in 
>> the following lines in commandLineFlagConstraintsCompiler.cpp:
>>
>> 243 "between %d and %d inclusively or -1(means no change) "
>> 244 "or %d(special value for critical thread class/priority)\n", 
>> Otherwise it looks good (I'm not a Reviewer). Please let me know if 
>> you need a sponsor. Thank you and best regards, Zoltan
>>
>>
>> On 10/30/2015 03:47 PM, Dmitry Dmitriev wrote:
>>> Hello,
>>>
>>> Please review this small fix for compiler constraint functions. 
>>> Several typos were fixed(missed space, missed argument to print 
>>> function) and also some refactoring was made(move range check to the 
>>> generic 'range()' macro etc.). Also, modified constraint for 
>>> AliasLevel level to disallow ran with low AliasLevel in mixed mode 
>>> to avoid crashes.
>>>
>>> Full description of the problems and solutions are in the JBS: 
>>> https://bugs.openjdk.java.net/browse/JDK-8141042
>>>
>>> I plan to push it to the hs-rt/hotspot repo, because related test 
>>> fix was also pushed to the hs-rt/hotspot repo.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8141042
>>> webrev.00: http://cr.openjdk.java.net/~ddmitriev/8141042/webrev.00/
>>> Testing: JPRT(hotspot test set), hotspot all, vm.quick
>>>
>>> Thanks,
>>> Dmitry
>>
>