[9] RFR 8131778: java disables UseAES flag when using VIS=2 on sparc
Vladimir Kozlov
vladimir.kozlov at oracle.com
Sat Oct 31 05:58:11 UTC 2015
Looks good.
Thanks,
Vladimir
On 10/31/15 12:39 AM, Konstantin Shefov wrote:
> Hi Vladimir,
>
> Thanks for reviewing.
>
> I have changed the webrev according to your comments:
> http://cr.openjdk.java.net/~kshefov/8131778/webrev.01
>
> -Konstantin
>
> On 10/30/2015 12:00 PM, Vladimir Kozlov wrote:
>> sparc:
>>
>> Indent is wrong for !UseAES } else { block.
>>
>> sparc and x86: you need to set flags to false in addition to warnings:
>>
>> } else if (UseAES || UseAESIntrinsics) {
>> + if (UseAES && !FLAG_IS_DEFAULT(UseAES)) {
>> warning("AES instructions are not available on this CPU");
>> }
>> ! if (UseAESIntrinsics && !FLAG_IS_DEFAULT(UseAESIntrinsics)) {
>> ! warning("AES intrinsics are not available on this CPU");
>> }
>>
>> Thanks,
>> Vladimir
>>
>> On 10/29/15 11:43 PM, Konstantin Shefov wrote:
>>> This is the fix of the issue when both flags "useAES" and
>>> "useAESIntrinsics" are disabled, although only "useAESIntrinsics" should
>>> be disabled if some instruction sets are not supported by a CPU.
>>>
>>> This fix has been tested by the slightly modified tests from
>>> https://bugs.openjdk.java.net/browse/JDK-8079667 (which will be resolved
>>> in the nearest future).
>>>
>>> -Konstantin
>>>
>>> On 10/27/2015 08:09 PM, Konstantin Shefov wrote:
>>>> Hello
>>>>
>>>> Please review a bug fix.
>>>>
>>>> JBS entry: https://bugs.openjdk.java.net/browse/JDK-8131778
>>>> Webrev: http://cr.openjdk.java.net/~kshefov/8131778/webrev.00
>>>>
>>>> Thanks
>>>> -Konstantin
>>>
>
More information about the hotspot-compiler-dev
mailing list