RFR(S): 8135069: C2 replaces range checks by unsigned comparison with -1
Roland Westrelin
roland.westrelin at oracle.com
Tue Sep 15 08:54:31 UTC 2015
Thanks for the review, Vladimir.
Roland.
> On Sep 14, 2015, at 6:06 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>
> Looks fine.
>
> Thanks,
> Vladimir
>
> On 9/14/15 5:28 AM, Roland Westrelin wrote:
>> http://cr.openjdk.java.net/~roland/8135069/webrev.00/
>>
>> Another corner case that’s not handled correctly by the code that folds 2 consecutive integer comparisons into a single unsigned comparison:
>>
>> i < 0 || i > -1 is folded as i >u -1. It should be i >=u 0. I refactored the code so it’s easier to relate the comments and the logic.
>>
>> Roland.
>>
More information about the hotspot-compiler-dev
mailing list