[9] RFR(S): 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes

[Aleksey Shipilev]

On 09/18/2015 02:00 PM, Tobias Hartmann wrote:
> On 18.09.2015 12:38, Aleksey Shipilev wrote:
>> On 09/18/2015 12:57 PM, Tobias Hartmann wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8136469
>>> http://cr.openjdk.java.net/~thartmann/8136469/webrev.00/
>> I think OptoStringConcat should fail gracefully on graph mismatch
>> anyway, not crash the fastdebug build. Is it possible to have anything
>> else besides Bool or Con as an input for If?
> 
> IfNode::Ideal() suggests that we could also have TOP but I don't think this should be possible right after parsing.

Understood. Well then, assert is also plausible then, since it asserts
the structural property of the Ideal itself, not the the subset of
accepted shapes. Your choice, really.

> To be save, we can also go with this fix:
> http://cr.openjdk.java.net/~thartmann/8136469/webrev.01/

+1 to this one as well.

Thanks,
-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20150918/7b14fa37/signature.asc>