RFR(XXS): 8136693: add package statement 'compiler.testlibrary' to CompilerUtils
Igor Ignatyev
igor.ignatyev at oracle.com
Fri Sep 18 20:23:58 UTC 2015
Tatiana,
good, thanks for verifying and fixing. I'm going to push that.
--
Thanks,
Igor
On 09/17/2015 08:35 PM, Tatiana Pivovarova wrote:
>
>
> On 09/17/2015 05:30 PM, Tatiana Pivovarova wrote:
>>
>>
>> On 09/17/2015 03:54 PM, Igor Ignatyev wrote:
>>> Hi Tatiana,
>>>
>>> the fix looks good.
>>> have you checked that the tests which use this class work fine after
>>> your changes?
>> I checked that SegmentedCodeCacheDtraceTest (the only test who used
>> CompilerUtils) compiled and I think this check is enough for such
>> changes.
> You were right. There was some bug. Jtreg couldn't find CompilerUtils in
> a new package. Now I point to correct path @library
>
> new webrev : http://cr.openjdk.java.net/~tpivovarova/8136693/webrev.01/
>
> ---
> Tatiana
>>>
>>> Igor
>>>
>>> On 09/17/2015 03:16 PM, Tatiana Pivovarova wrote:
>>>> Hi guys!
>>>>
>>>> Please review this small enhancement.
>>>> JRE : https://bugs.openjdk.java.net/browse/JDK-8136693
>>>> webrev : http://cr.openjdk.java.net/~tpivovarova/8136693/webrev.00/
>>>>
>>>> To fix error 'error: cannot find symbol' 'symbol: variable
>>>> CompilerUtils' it needs to add
>>>>
>>>> packagecompiler.testlibrary;
>>>>
>>>> to CompilerUtils class
>>>>
>>>> ---
>>>> Thanks,
>>>> Tatiana
>>>>
>>
>
More information about the hotspot-compiler-dev
mailing list