RFR (M): 8066157 JEP-165: Test task: method matcher

Pavel Punegov pavel.punegov at oracle.com
Tue Sep 22 14:56:06 UTC 2015


Thanks, Nils.

I updated the test and made it able to validate < and >.
Here is a webrev: http://cr.openjdk.java.net/~ppunegov/8066157/webrev.01/

On 18.09.2015 12:42, Nils Eliasson wrote:
> Hi Pavel,
>
> I updated the matcher code to properly validate < and > tokens so you 
> have to update the test to reflect that. Otherwise the test looks good 
> - runs fast, tests what it should, and give good feedback on errors.
>
> Thanks,
> //Nils
> (Not a reviewer)
>
> Thanks for
>
> On 2015-09-17 21:49, Pavel Punegov wrote:
>> Hi all,
>>
>> Please review the following new test for the first part of  JEP 165: 
>> CompilerControl development:
>> 8135068: Extract methodmatchers from CompilerOracle
>>
>> Test generates random method signatures (valid and invalid) to check 
>> matching via WB method from the change for JDK-8135068.
>> Each signature is checked for all of the methods got from the pool of 
>> classes to ensure correctness of MethodMatcher.
>>
>> webrev: http://cr.openjdk.java.net/~ppunegov/8066157/webrev.00/
>> bug:  https://bugs.openjdk.java.net/browse/JDK-8066157
>>
>

-- 
Thanks,
Pavel Punegov



More information about the hotspot-compiler-dev mailing list