RFR(M) 8151003 remove nds validity checks from vex x86 assembler

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Apr 4 23:25:02 UTC 2016


Bug number in links is incorrect. Should be:

https://bugs.openjdk.java.net/browse/JDK-8151003
http://cr.openjdk.java.net/~mcberg/8151003/webrev.02/

Changes looks good. Very nice clean up. I will start testing.

I see you changed code for AVX > 2 in macroAssembler_x86.hpp. Is it 
because new instructions faster or to avoid mixing evex and non-evex 
instructions?

Thanks,
Vladimir

On 4/1/16 2:51 PM, Berg, Michael C wrote:
> Hi All,
>
> I would like to contribute some clean up on the x86 assembler applied to
> vex encoding to address the usage of the nds assembler parameter.
>
> For all instructions which use nds source xmm registers, the validity
> check has been removed.  It was originally placed there here:
>
> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/006050192a5a#l1.1269
>
> And propagated.  Now nds register usage is fully compliant with each isa
> descrption.
>
>
> Bug-id: https://bugs.openjdk.java.net/browse/JDK-8151001
> webrev:
>
> http://cr.openjdk.java.net/~mcberg/8151001/webrev.02/
>
> Thanks,
>
> Michael
>


More information about the hotspot-compiler-dev mailing list