RFR (M): 8152907: Update for tan and log10 for x86

[Deshpande, Vivek R]

Hi Christian

We have updated the patch as per the suggested changes.
The webrev for the same is at this location for your review.
http://cr.openjdk.java.net/~vdeshpande/libm_tanlog10/8152907/webrev.01/

We will soon send another patch for CompilerDirectives changes.

Regards,
Vivek

From: Christian Thalinger [mailto:christian.thalinger at oracle.com]
Sent: Tuesday, March 29, 2016 11:29 AM
To: Rukmannagari, Shravya
Cc: Deshpande, Vivek R; Vladimir Kozlov; hotspot compiler
Subject: Re: RFR (M): 8152907: Update for tan and log10 for x86


On Mar 29, 2016, at 6:38 AM, Rukmannagari, Shravya <shravya.rukmannagari at intel.com<mailto:shravya.rukmannagari at intel.com>> wrote:

Hi Christian,
We would add separate files for each intrinsic. By splitting the CompilerDirectives, do you mean we have to add a separate file. Sorry I didn’t exactly get it.

Oh, sorry, I wasn’t clear enough.  Please file a new enhancement for the CompilerDirectives changes and integrate them separately.



Thanks,
Shravya Rukmannagari.

From: Christian Thalinger [mailto:christian.thalinger at oracle.com]
Sent: Monday, March 28, 2016 5:18 PM
To: Deshpande, Vivek R <vivek.r.deshpande at intel.com<mailto:vivek.r.deshpande at intel.com>>
Cc: hotspot compiler <hotspot-compiler-dev at openjdk.java.net<mailto:hotspot-compiler-dev at openjdk.java.net>>; Vladimir Kozlov <vladimir.kozlov at oracle.com<mailto:vladimir.kozlov at oracle.com>>; Rukmannagari, Shravya <shravya.rukmannagari at intel.com<mailto:shravya.rukmannagari at intel.com>>
Subject: Re: RFR (M): 8152907: Update for tan and log10 for x86

I left this comment in the bug:

I think for the saneness of the macroAssembler_libm_x86_*.cpp files we should put every intrinsic in its own file, like we did for macroAssembler_x86_sha.cpp. They are already too big:

$ wc -l hotspot/src/cpu/x86/vm/macroAssembler_libm_x86_*.cpp
    4571 hotspot/src/cpu/x86/vm/macroAssembler_libm_x86_32.cpp
    3945 hotspot/src/cpu/x86/vm/macroAssembler_libm_x86_64.cpp

Also, can we split out the CompilerDirectives changes?



On Mar 28, 2016, at 1:52 PM, Deshpande, Vivek R <vivek.r.deshpande at intel.com<mailto:vivek.r.deshpande at intel.com>> wrote:

Hi all

We would like to contribute a patch which optimizes tan and log10 X86 architecture using Intel LIBM library.
Could you please review and sponsor this patch.

Bug-id:
https://bugs.openjdk.java.net/browse/JDK-8152907
webrev:
http://cr.openjdk.java.net/~vdeshpande/libm_tanlog10/8152907/webrev.00/

Thanks and regards,
Vivek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160405/ab29b09e/attachment.html>