RFR(S) 8153115: Move private interface check to linktime
Karen Kinnear
karen.kinnear at oracle.com
Tue Apr 5 18:12:41 UTC 2016
Igor,
I’d like to get back to you on this before you check in the change please. I need to sanity check the JVMS and the
code.
I have another set of tests written by Vladimir Ivanov that I will send you as well.
thanks,
Karen
> On Apr 5, 2016, at 11:57 AM, Igor Veresov <igor.veresov at oracle.com> wrote:
>
> Thanks, Tom!
>
> igor
>
>> On Apr 5, 2016, at 8:21 AM, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
>>
>> looks good to me.
>>
>> tom
>>
>>> On Apr 1, 2016, at 11:28 AM, Igor Veresov <igor.veresov at oracle.com> wrote:
>>>
>>> When invoking private interface methods with invokeinterface we throw ICCE. The check for that happens in the runtime part of the resolution, however, doing it at linktime seems like a better place, since the check doesn't depend on the receiver type. It also allows compiler interfaces that rely on linktime resolution to detect inconsistencies during parsing (see ciEnv::lookup_method() (CI) and ConstantPool.lookupMethod() (JVMCI) that are affected).
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8153115
>>> Webrev: http://cr.openjdk.java.net/~iveresov/8153115/webrev.00/
>>>
>>> Thanks,
>>> igor
>>
>
More information about the hotspot-compiler-dev
mailing list