RFR (M): 8152907: Update for tan and log10 for x86

[Vladimir Kozlov]

Problem found during build. Looks like we need #include 
"runtime/sharedRuntime.hpp" in templateInterpreterGenerator_x86_64.cpp:

hotspot/src/cpu/x86/vm/templateInterpreterGenerator_x86_64.cpp:379:56: 
error: use of undeclared identifier 'SharedRuntime'
__ call(RuntimeAddress(CAST_FROM_FN_PTR(address, SharedRuntime::dexp)));

Note templateInterpreterGenerator_x86_32.cpp has that #include.

It was on macosx where -DDONT_USE_PRECOMPILED_HEADER is used.

Vladimir



On 4/5/16 2:27 PM, Deshpande, Vivek R wrote:
> HI Vladimir
>
> Sorry about that.
> Please check this webrev
> http://cr.openjdk.java.net/~vdeshpande/libm_tanlog10/8152907/webrev.02/
> I have updated it.
>
> Regards,
> Vivek
>
> -----Original Message-----
> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> Sent: Tuesday, April 05, 2016 1:47 PM
> To: Deshpande, Vivek R; Rukmannagari, Shravya
> Cc: hotspot compiler
> Subject: Re: RFR (M): 8152907: Update for tan and log10 for x86
>
> I again can't apply changes because of CR at the end of lines in patch file.
>
> Vladimir
>
> On 4/5/16 1:41 PM, Deshpande, Vivek R wrote:
>>
>> Hi Vladimir
>>
>> I will send you the patch with macroAssembler_libm_x86_*.cpp files removed.
>> Thank you for the review.
>>
>> Regards,
>> Vivek
>> -----Original Message-----
>> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
>> Sent: Tuesday, April 05, 2016 1:34 PM
>> To: Deshpande, Vivek R; Christian Thalinger; Rukmannagari, Shravya
>> Cc: hotspot compiler
>> Subject: Re: RFR (M): 8152907: Update for tan and log10 for x86
>>
>> It looks good to me but I don't see macroAssembler_libm_x86_*.cpp files changes in webrev. Did you used 'hg remove' or simple removed them?
>>
>> I will start pre-integration testing.
>>
>> Thanks,
>> Vladimir
>>
>> On 4/4/16 11:25 PM, Deshpande, Vivek R wrote:
>>> Hi Christian
>>>
>>> We have updated the patch as per the suggested changes.
>>>
>>> The webrev for the same is at this location for your review.
>>>
>>> http://cr.openjdk.java.net/~vdeshpande/libm_tanlog10/8152907/webrev.0
>>> 1
>>> /
>>>
>>> We will soon send another patch for CompilerDirectives changes.
>>>
>>> Regards,
>>>
>>> Vivek
>>>
>>> *From:*Christian Thalinger [mailto:christian.thalinger at oracle.com]
>>> *Sent:* Tuesday, March 29, 2016 11:29 AM
>>> *To:* Rukmannagari, Shravya
>>> *Cc:* Deshpande, Vivek R; Vladimir Kozlov; hotspot compiler
>>> *Subject:* Re: RFR (M): 8152907: Update for tan and log10 for x86
>>>
>>>       On Mar 29, 2016, at 6:38 AM, Rukmannagari, Shravya
>>>       <shravya.rukmannagari at intel.com
>>>       <mailto:shravya.rukmannagari at intel.com>> wrote:
>>>
>>>       Hi Christian,
>>>
>>>       We would add separate files for each intrinsic. By splitting the
>>>       CompilerDirectives, do you mean we have to add a separate file.
>>>       Sorry I didn’t exactly get it.
>>>
>>> Oh, sorry, I wasn’t clear enough.  Please file a new enhancement for
>>> the CompilerDirectives changes and integrate them separately.
>>>
>>>
>>>
>>> Thanks,
>>>
>>> Shravya Rukmannagari.
>>>
>>> *From:*Christian Thalinger [mailto:christian.thalinger at oracle.com]
>>> *Sent:*Monday, March 28, 2016 5:18 PM *To:*Deshpande, Vivek R
>>> <vivek.r.deshpande at intel.com <mailto:vivek.r.deshpande at intel.com>>
>>> *Cc:*hotspot compiler <hotspot-compiler-dev at openjdk.java.net
>>> <mailto:hotspot-compiler-dev at openjdk.java.net>>; Vladimir Kozlov
>>> <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>>;
>>> Rukmannagari, Shravya <shravya.rukmannagari at intel.com
>>> <mailto:shravya.rukmannagari at intel.com>>
>>> *Subject:*Re: RFR (M): 8152907: Update for tan and log10 for x86
>>>
>>> I left this comment in the bug:
>>>
>>> I think for the saneness of the macroAssembler_libm_x86_*.cpp files
>>> we should put every intrinsic in its own file, like we did for
>>> macroAssembler_x86_sha.cpp. They are already too big:
>>>
>>> $ wc -l hotspot/src/cpu/x86/vm/macroAssembler_libm_x86_*.cpp
>>>        4571 hotspot/src/cpu/x86/vm/macroAssembler_libm_x86_32.cpp
>>>        3945 hotspot/src/cpu/x86/vm/macroAssembler_libm_x86_64.cpp
>>>
>>> Also, can we split out the CompilerDirectives changes?
>>>
>>>
>>>
>>>
>>>       On Mar 28, 2016, at 1:52 PM, Deshpande, Vivek R
>>>       <vivek.r.deshpande at intel.com <mailto:vivek.r.deshpande at intel.com>>
>>>       wrote:
>>>
>>>       Hi all
>>>
>>>       We would like to contribute a patch which optimizestan and log10
>>>       X86architecture usingIntel LIBM library.
>>>
>>>       Could you please review and sponsor this patch.
>>>
>>>       Bug-id:
>>>
>>>       https://bugs.openjdk.java.net/browse/JDK-8152907
>>>       webrev:
>>>
>>>
>>> http://cr.openjdk.java.net/~vdeshpande/libm_tanlog10/8152907/webrev.0
>>> 0
>>> /
>>>
>>>       Thanks and regards,
>>>
>>>       Vivek
>>>