RFR(S): 8153013: BlockingCompilation test times out

[Nils Eliasson]

Tasks get evicted from the compile_queue if their invocation counter 
hasn't increased during TieredCompileTaskTimeout. 
(AdvancedThresholdPolicy::is_stale(...)).

I'll do a proper fix, it is the right thing to do and should be pretty 
quick. I'll change the comment to an enum that represent who submitted 
the compile, and add a table for the comments. This could be useful in 
other settings to.

Regards,
Nils

On 2016-04-08 19:09, Vladimir Kozlov wrote:
> What do you mean "stale"?
> I would prefer to see the real fix as you suggested to avoid removing 
> WB comp tasks from queue. Adding timeout is not reliable.
>
> Thanks,
> Vladimir
>
> On 4/8/16 5:27 AM, Nils Eliasson wrote:
>> Hi,
>>
>> Please review this small fix of the BlockingCompilation test.
>>
>> Summary:
>> Add method enqueued for compilation with WB API may be removed from 
>> the compile queue as stale.
>>
>> Solution:
>> Add -XX:TieredCompileTaskTimeout=60000 to make sure nothing gets 
>> stale while the test is running. (Also added some extra
>> checks that may spare us from waiting until timeout for failing.)
>>
>> This is an workaround but we should consider fixing something 
>> permanent for WB API compiles - like tagging the compile
>> task with info about the origin of the compile. The comment field has 
>> this information - but then it needs to be
>> converted to an enum.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8153013
>> Webrev: http://cr.openjdk.java.net/~neliasso/8153013/webrev.01/
>>
>> Best regards,
>> Nils Eliasson
>>
>>
>>
>>