[9] RFR (XS): 8151708: C1 FastTLABRefill can allocate TLABs past the end of the heap

[Zoltán Majó]

Thank you, Vladimir and Tobias, for the review!

Best regards,


Zoltan

On 04/14/2016 08:57 PM, Vladimir Kozlov wrote:
> Good.
>
> Thanks,
> Vladimir
>
> On 4/14/16 5:26 AM, Zoltán Majó wrote:
>> Hi Tobias,
>>
>>
>> thank you for the feedback!
>>
>> On 04/14/2016 02:15 PM, Tobias Hartmann wrote:
>>> [...]
>>> I would simply replace the 'br' by 'brx' which tests either xcc or 
>>> icc depending on the architecture.
>>
>> Yes, that simplifies the code a bit. Here is the updated webrev:
>> http://cr.openjdk.java.net/~zmajo/8151708/webrev.01/
>>
>> Tests are running.
>>
>> Thank you!
>>
>> Best regards,
>>
>>
>> Zoltan
>>
>>>
>>> Best regards,
>>> Tobias
>>>
>>>> Solution: As the VM is handling addresses at the above-mentioned 
>>>> locations, the appropriate condition codes are supposed to be 
>>>> checked. Use 'BPcc' instead of 'Bicc' at these locations.
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~zmajo/8151708/webrev.00/
>>>>
>>>> Testing:
>>>> - JPRT
>>>> - reproducer on solaris_sparc.
>>>>
>>>> Thank you!
>>>>
>>>> Best regards,
>>>>
>>>>
>>>> Zoltan
>>>>
>>