RFR (S): 8154473: Update for CompilerDirectives to control stub generation and intrinsics

[Deshpande, Vivek R]

Hi Volkar

Thanks for your review and comments. I will surely take care of these things you mentioned.
I am using mathfunc() to methods which call SharedRuntime::d(exp, pow, sin, cos, tan, log, log10) as an alternate when DisableIntrinsic is used to not use LIBM intrinsics.

Thanks and regards,
Vivek



-----Original Message-----
From: Volker Simonis [mailto:volker.simonis at gmail.com] 
Sent: Tuesday, April 19, 2016 1:47 AM
To: Deshpande, Vivek R
Cc: hotspot compiler; Vladimir Kozlov; Christian Thalinger
Subject: Re: RFR (S): 8154473: Update for CompilerDirectives to control stub generation and intrinsics

Hi Vivek,

you introduce the new method TemplateInterpreterGenerator::mathfunc()
but only implement it on x86_64. Shouldn't we have at least empty implementations of this method for all architectures?

Also the description in the bug sounds quite general but you only seem to implement it for certain math-intrinsics on x64.

Another minor nit: in vmSymbols.hpp I don't think we need the const qualifier on the ID argument because it is only an enum anyway:

+  static bool is_disabled_by_flags(const vmIntrinsics::ID id);

It makes sense on:

static bool is_disabled_by_flags(const methodHandle& method);

because here we are passing method by reference and the const qualifier guaranties that is_disabled_by_flags will not change the method.

Regards,
Volker


On Mon, Apr 18, 2016 at 7:38 PM, Deshpande, Vivek R <vivek.r.deshpande at intel.com> wrote:
> Hi all
>
>
>
> I would like to contribute a patch which helps to control the 
> intrinsics in interpreter, c1 and c2 by disabling the stub generation.
>
> This uses -XX:DisableIntrinsic option to achieve the same.
>
> Could you please review and sponsor this patch.
>
>
>
> Bug-id:
>
> https://bugs.openjdk.java.net/browse/JDK-8154473
> webrev:
>
> http://cr.openjdk.java.net/~vdeshpande/CompilerDirectives/8154473/webr
> ev.00/
>
>
>
> Thanks and regards,
>
> Vivek
>
>