[9] RFR(XS): 8154763: Crash with "assert(RangeCheckElimination)" if RangeCheckElimination is disabled

[Tobias Hartmann]

Hi Michael,

On 21.04.2016 16:42, Berg, Michael C wrote:
> Hi Tobias, sure when RangeCheckElimination is not enabled this makes sense.

thanks for the review!

Best regards,
Tobias

> 
> Thanks,
> Michael
> 
> -----Original Message-----
> From: Tobias Hartmann [mailto:tobias.hartmann at oracle.com] 
> Sent: Thursday, April 21, 2016 6:57 AM
> To: hotspot-compiler-dev at openjdk.java.net
> Cc: Berg, Michael C <michael.c.berg at intel.com>
> Subject: [9] RFR(XS): 8154763: Crash with "assert(RangeCheckElimination)" if RangeCheckElimination is disabled
> 
> Hi,
> 
> please review the following patch:
> 
> https://bugs.openjdk.java.net/browse/JDK-8154763
> http://cr.openjdk.java.net/~thartmann/8154763/webrev.00/
> 
> JDK-8151573 introduced multiversioning for range check elimination. Explicitly turning of range check elimination now crashes the VM with an assert in PhaseIdealLoop::has_range_checks() because we assume that this is only called if range check elimination is enabled.
> 
> I think we should disable multiversioning if range check elimination is turned off. I added the corresponding check.
> 
> Tested with regression test and RBT (running).
> 
> Thanks,
> Tobias
>