[9] RFR(XS): 8154763: Crash with "assert(RangeCheckElimination)" if RangeCheckElimination is disabled

[Tobias Hartmann]

Hi Chris,

On 21.04.2016 23:18, Christian Thalinger wrote:
> Not a review but I think PostLoopMultiversioning should be a diagnostic_pd.  I’ve added a comment to this Enhancement:
> 
> https://bugs.openjdk.java.net/browse/JDK-8150900

Yes, I agree. We should avoid adding too many new product flags.

Thanks,
Tobias

> 
>> On Apr 21, 2016, at 3:56 AM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:
>>
>> Hi,
>>
>> please review the following patch:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8154763
>> http://cr.openjdk.java.net/~thartmann/8154763/webrev.00/
>>
>> JDK-8151573 introduced multiversioning for range check elimination. Explicitly turning of range check elimination now crashes the VM with an assert in PhaseIdealLoop::has_range_checks() because we assume that this is only called if range check elimination is enabled.
>>
>> I think we should disable multiversioning if range check elimination is turned off. I added the corresponding check.
>>
>> Tested with regression test and RBT (running).
>>
>> Thanks,
>> Tobias
>>
>