RFR: 8153655: Make intrinsics flags diagnostic and update intrinsics tests to enable diagnostic options.

[Rahul Raghavan]

Hi,

Please review the following patch for JDK-8153655.

Bug: https://bugs.openjdk.java.net/browse/JDK-8153655
Webrev: http://cr.openjdk.java.net/~rraghavan/8153655/webrev.00/


Notes:

1. This 8153655/webrev.00 re-includes earlier backed out, same JDK-8145348 changes 
       (https://bugs.openjdk.java.net/browse/JDK-8145348 - Make intrinsics flags diagnostic)
and also additional fixes in failing intrinsic tests.


2. Checked all the usages of changed intrinsic flags in tests and 
found JDK-8153655 type test failure issue (after initial JDK-8145348 fix) is present only for following tests -
   a. UseAESIntrinsics test (compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java)
   b. UseSHA* tests (at compiler/intrinsics/sha/cli/)


3. Summary of 8153655/webrev.00 changes.

- Includes earlier backed out, same JDK-8145348 changes:
       src/share/vm/c1/c1_globals.hpp
       src/share/vm/opto/c2_globals.hpp
       src/share/vm/runtime/globals.hpp
       test/compiler/intrinsics/muladd/TestMulAdd.java
       test/compiler/runtime/6859338/Test6859338.java

- 'test/compiler/cpuflags/AESIntrinsicsBase.java'
      Options were passed in wrong order. 
      Changes done so that 'UnlockDiagnosticVMOptions' option precedes the diagnostic flags.

- 'test/compiler/intrinsics/sha/cli/*' - (UseSHA* tests)
     'UnlockDiagnosticVMOptions' option was not getting passed.
     Added support to precede intrinsic flag usages with explicit 'UnlockDiagnosticVMOptions'.


4. No issues found with testing done using product builds with proposed changes 
(hotspot/test/compiler/cpuflags/*, hotspot/test/compiler/intrinsics/*, hotspot/test/compiler/runtime/6859338/Test6859338.java)
Complete pre-integration testing using product builds is in progress.


Thanks,
Rahul