RFR(XS): 8155163 - JVMCI: MethodHandleAccessProvider.resolveInvokeBasicTarget implementation doesn't match javadoc

Christian Thalinger christian.thalinger at oracle.com
Thu Apr 28 19:03:34 UTC 2016


Looks good.

> On Apr 28, 2016, at 4:28 AM, Dmitrij Pochepko <dmitrij.pochepko at oracle.com> wrote:
> 
> Hi,
> 
> please review fix for JDK-8155163 - JVMCI: MethodHandleAccessProvider.resolveInvokeBasicTarget implementation doesn't match javadoc
> 
> MethodHandleAccessProvider.resolveInvokeBasicTarget implementation throws NPE in case 1st parameter doesn't represent MethodHandle, but according to javadoc it should return null in such case. So, a small fix should be applied to match javadoc.
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8155163 <https://bugs.openjdk.java.net/browse/JDK-8155163>
> Webrev: http://cr.openjdk.java.net/~dpochepk/8155163/webrev.01/ <http://cr.openjdk.java.net/~dpochepk/8155163/webrev.01/>
> 
> I've tested this change on linux_x64 via jprt.
> 
> Thanks,
> Dmitrij

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160428/22e87449/attachment.html>


More information about the hotspot-compiler-dev mailing list