RFR 8154483: update IGV with improvements from Graal

Tom Rodriguez tom.rodriguez at oracle.com
Fri Apr 29 04:17:54 UTC 2016


> On Apr 28, 2016, at 5:14 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Wow, did we really got IGV at 1998?

I think it contains some elements that are that old but IGV was integrated into the hotspot repo in 2008.  It existed for a few years before that as Thomas’s thesis project, so maybe 2006?

tom

> 
> Looks good.
> 
> Thanks,
> Vladimir
> 
> On 4/28/16 5:08 PM, Tom Rodriguez wrote:
>> 
>>> On Apr 28, 2016, at 5:05 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>> 
>>> On 4/28/16 4:57 PM, Tom Rodriguez wrote:
>>>> 
>>>>> On Apr 28, 2016, at 3:55 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>>>> 
>>>>> Looks good.
>>>>> 
>>>>> In serialization/BinaryParser.java Copyright year change is wrong.
>>>> 
>>>> Thanks, I think there are copyright updates in JDK9 that aren’t in 8 so I accidentally overwrote it when creating this patch.  I’ll fix it.  Actually, should I go ahead and update the copyright years for all these files?
>>> 
>>> Yes, please.
>> 
>> They’re all updated.
>> 
>> tom
>> 
>>> 
>>> Thanks,
>>> Vladimir
>>> 
>>>> 
>>>> tom
>>>> 
>>>>> 
>>>>> Thanks,
>>>>> Vladimir
>>>>> 
>>>>> On 4/28/16 9:26 AM, Tom Rodriguez wrote:
>>>>>> http://cr.openjdk.java.net/~never/8154483/webrev
>>>>>> 
>>>>>> This is a collection of small improvements to IGV developed while working on Graal.  I’ve categorized them below
>>>>>> 
>>>>>> Bug fixes:
>>>>>>   Reset folder in top component to release reference to old graphs
>>>>>>   Fix concurrent modification exception in IGV
>>>>>>   Fix HTML quoting in tooltips and remove useless entries from search box
>>>>>> 
>>>>>> UI improvements:
>>>>>>   Fixed keybinding for open and save actions in IGV
>>>>>>   Allow importing multiple files at once in IGV
>>>>>>   Make node searches look through the graph history for a match
>>>>>> 
>>>>>> Performance related improvements:
>>>>>>   Add info message about time spent parsing files
>>>>>>   Relax expensive assert in IGV
>>>>>>   Reduce overhead of hash computation for graph identity checks
>>>>>>   Increase Integer cache size in IGV
>>>>>>   Share properties in IGV
>>>>>> 
>>>>>> Binary graph format:
>>>>>>   Add folder and graph property support to binary graphs in IGV
>>>>>>   Handle Strings larger than buffer size properly in IGV
>>>>>> 
>>>> 
>> 



More information about the hotspot-compiler-dev mailing list