RFR(XS): 8155244 - JVMCI: MemoryAccessProvider.readUnsafeConstant javadoc should be updated for null JavaKind case

[Christian Thalinger]

Looks good.

> On Apr 29, 2016, at 6:00 AM, dmitrij pochepko <dmitrij.pochepko at oracle.com> wrote:
> 
> Hi,
> I've updated javadoc according to comment.
> 
> Please take a look at updated version:
> 
> http://cr.openjdk.java.net/~dpochepk/8155244/webrev.02/ <http://cr.openjdk.java.net/~dpochepk/8155244/webrev.02/>
> 
> Thanks,
> Dmitrij
> 
>> +     * @throws IllegalArgumentException if {@code kind} is {@code null}, {@code kind} is {@link JavaKind#Void} or
>> +     *             not {@linkplain JavaKind#isPrimitive() primitive} kind
>> I don’t think you have to repeat {@code kind}.
>> 
>>> On Apr 28, 2016, at 6:39 AM, Dmitrij Pochepko <dmitrij.pochepko at oracle.com <mailto:dmitrij.pochepko at oracle.com>> wrote:
>>> 
>>> Hi,
>>> 
>>> please review changes for 8155244 - JVMCI: MemoryAccessProvider.readUnsafeConstant javadoc should be updated for null JavaKind case
>>> 
>>> MemoryAccessProvider.readUnsafeConstant method implementation throws NullPointerException in case JavaKind is null. Such behavior wasn't specified in javadoc.
>>> So, a small fix contains logic to throw IllegalArgumentException and respective javadoc update.
>>> 
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8155244 <https://bugs.openjdk.java.net/browse/JDK-8155244>
>>> webrev: http://cr.openjdk.java.net/~dpochepk/8155244/webrev.01/ <http://cr.openjdk.java.net/%7Edpochepk/8155244/webrev.01/>
>>> 
>>> I've tested fix on linux_x64 via jprt.
>>> 
>>> Thanks,
>>> Dmitrij
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160429/c4de9978/attachment.html>