RFR(XS): 8155738: C2: fix frame_complete_offset

Dean Long dean.long at oracle.com
Fri Apr 29 20:51:15 UTC 2016


Looks good.  I will closed JDK-8008415 as a duplicate!

dl


On 4/29/2016 9:55 AM, Vladimir Kozlov wrote:
> "In the debug build the call at output.cpp:1831 build if 
> (n->size(_regalloc) < (current_offset-instr_offset)) overwrites the 
> proper value."
>
> So the fix is to not reset frame_complete_offset 
> (Compile::_code_offsets._values[Frame_Complete]) when node is emitted 
> into scratch buffer.
>
> Changes looks good.
>
> Thanks,
> Vladimir
>
> On 4/29/16 7:09 AM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>>
>>
>> In C2, frame_complete_offset is set wrong.  It’s also called during 
>> scratch_emit_size,
>>
>> which happens at least in the debug build.
>>
>> I also added the missing call on ppc.
>>
>>
>>
>> Please review this small fix.  I please need a sponsor:
>>
>> http://cr.openjdk.java.net/~goetz/wr16/8155738-frameCmplt/webrev.00/
>>
>>
>>
>> Thanks and best regards,
>>
>>   Goetz.
>>



More information about the hotspot-compiler-dev mailing list