RFR: 8163589: Add back intrinsic methods for event based tracing

[Aleksey Shipilev]

On 08/10/2016 05:05 PM, Robbin Ehn wrote:
> Hi all,
> 
> In 8 we had this intrinsic, I'm adding it back
> Used for event based tracing.
> 
> Webrev: http://cr.openjdk.java.net/~rehn/8163589/hotspot.01/webrev/

Looks okay.

*) c1_LIRGenerator:

3097   __ move(new LIR_Address(arg.result(),
java_lang_Class::klass_offset_in_bytes(), klass_pointer_type), klass, info);

Should klass_pointer_type be T_ADDRESS? It is an injected field of
intptr_t type, so current code seems fine, but T_ADDRESS matches the
existing uses in C1 better.

*) Are these different? Do we want to use one of these consistently?

C1:
3099   ByteSize offset = TRACE_KLASS_TRACE_ID_OFFSET;

C2:
3169   ByteSize offset = InstanceKlass::trace_id_offset();


*) Is the new intrinsic different from other catered by
LibraryCallKit::inline_native_Class_query?


Thanks,
-Aleksey



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160810/3e336229/signature-0001.asc>