RFR(L): 8156852: Convert JSON_test to Gtest

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Mon Aug 15 17:40:06 UTC 2016


Pavel,

A bit of nitpicking:

1. Could you please renew year in copyright in 
http://cr.openjdk.java.net/~ppunegov/8156852/webrev/raw_files/new/src/share/vm/utilities/json.cpp 
?
2. Some lines 
http://cr.openjdk.java.net/~ppunegov/8156852/webrev/test/native/utilities/test_json.cpp.html 
are too long. Could you please re-format them?

Thank you.

Regards, Kirill

On 15.08.2016 20:27, Pavel Punegov wrote:
> Please review this fix converting JSON_test from internalVMTests to Gtest.
> All test cases in JSONTest::test() converted to Gtest’s TEST.
> Replaced a UTF symbols to appropriate hex-representations.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8156852
> webrev: http://cr.openjdk.java.net/~ppunegov/8156852/webrev/ 
> <http://cr.openjdk.java.net/%7Eppunegov/8156852/webrev/>
>
> — Thanks,
> Pavel Punegov
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160815/7555ea0c/attachment.html>


More information about the hotspot-compiler-dev mailing list