RFR(L): 8156852: Convert JSON_test to Gtest
Vladimir Kozlov
vladimir.kozlov at oracle.com
Tue Aug 16 17:01:32 UTC 2016
Good.
Thanks,
Vladimir
On 8/16/16 7:19 AM, Pavel Punegov wrote:
> Kirill and Vladimir,
>
> Fixed copyright year and long lines.
> New webrev: http://cr.openjdk.java.net/~ppunegov/8156852/webrev.01/
>
> — Thanks,
> Pavel Punegov
>
>> On 15 Aug 2016, at 20:40, Kirill Zhaldybin
>> <kirill.zhaldybin at oracle.com <mailto:kirill.zhaldybin at oracle.com>> wrote:
>>
>> Pavel,
>>
>> A bit of nitpicking:
>>
>> 1. Could you please renew year in copyright in
>> http://cr.openjdk.java.net/~ppunegov/8156852/webrev/raw_files/new/src/share/vm/utilities/json.cpp
>> ?
>> 2. Some lines
>> http://cr.openjdk.java.net/~ppunegov/8156852/webrev/test/native/utilities/test_json.cpp.html
>> are too long. Could you please re-format them?
>>
>> Thank you.
>>
>> Regards, Kirill
>>
>> On 15.08.2016 20:27, Pavel Punegov wrote:
>>> Please review this fix converting JSON_test from internalVMTests to
>>> Gtest.
>>> All test cases in JSONTest::test() converted to Gtest’s TEST.
>>> Replaced a UTF symbols to appropriate hex-representations.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8156852
>>> webrev: http://cr.openjdk.java.net/~ppunegov/8156852/webrev/
>>> <http://cr.openjdk.java.net/%7Eppunegov/8156852/webrev/>
>>>
>>> — Thanks,
>>> Pavel Punegov
>>>
>>
>
More information about the hotspot-compiler-dev
mailing list