RFR(L): 8156852: Convert JSON_test to Gtest

[Pavel Punegov]

Hi,

I’ve updated the review with changed test_json.cpp. I’ve returned back UTF symbols that was replaced to \u2603 (see lines 348-364 in test_json.cpp)

I found that the VS compiler is unable to handle such UTF representation so build fails on Windows with:
warning C4566: character represented by universal-character-name '\u2603' cannot be represented in the current code page (1252)

here is a new webrev: http://cr.openjdk.java.net/~ppunegov/8156852/webrev.02/ <http://cr.openjdk.java.net/~ppunegov/8156852/webrev.02/>

— Thanks,
Pavel Punegov

> On 17 Aug 2016, at 17:32, Pavel Punegov <pavel.punegov at oracle.com> wrote:
> 
> Thank you for review Vladimir
> 
>> On 16 Aug 2016, at 20:01, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> 
>> Good.
>> 
>> Thanks,
>> Vladimir
>> 
>> On 8/16/16 7:19 AM, Pavel Punegov wrote:
>>> Kirill and Vladimir,
>>> 
>>> Fixed copyright year and long lines.
>>> New webrev: http://cr.openjdk.java.net/~ppunegov/8156852/webrev.01/
>>> 
>>> — Thanks,
>>> Pavel Punegov
>>> 
>>>> On 15 Aug 2016, at 20:40, Kirill Zhaldybin
>>>> <kirill.zhaldybin at oracle.com <mailto:kirill.zhaldybin at oracle.com>> wrote:
>>>> 
>>>> Pavel,
>>>> 
>>>> A bit of nitpicking:
>>>> 
>>>> 1. Could you please renew year in copyright in
>>>> http://cr.openjdk.java.net/~ppunegov/8156852/webrev/raw_files/new/src/share/vm/utilities/json.cpp
>>>> ?
>>>> 2. Some lines
>>>> http://cr.openjdk.java.net/~ppunegov/8156852/webrev/test/native/utilities/test_json.cpp.html
>>>> are too long. Could you please re-format them?
>>>> 
>>>> Thank you.
>>>> 
>>>> Regards, Kirill
>>>> 
>>>> On 15.08.2016 20:27, Pavel Punegov wrote:
>>>>> Please review this fix converting JSON_test from internalVMTests to
>>>>> Gtest.
>>>>> All test cases in JSONTest::test() converted to Gtest’s TEST.
>>>>> Replaced a UTF symbols to appropriate hex-representations.
>>>>> 
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8156852
>>>>> webrev: http://cr.openjdk.java.net/~ppunegov/8156852/webrev/
>>>>> <http://cr.openjdk.java.net/%7Eppunegov/8156852/webrev/>
>>>>> 
>>>>> — Thanks,
>>>>> Pavel Punegov
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160819/4f2360ef/attachment.html>