RFR: 8164214: [JVMCI] include VarHandle in signature polymorphic method test
Doug Simon
doug.simon at oracle.com
Wed Aug 24 09:33:55 UTC 2016
> On 24 Aug 2016, at 02:01, John Rose <john.r.rose at oracle.com> wrote:
>
> On Aug 20, 2016, at 12:59 AM, Doug Simon <doug.simon at oracle.com> wrote:
>>
>>>
>>> On 20 Aug 2016, at 02:26, Paul Sandoz <paul.sandoz at oracle.com> wrote:
>>>
>>> It may be better to expose a new enum value in Flags and set the bit based on the _intrinsic_id, rather than JVMCI checking the range.
>>>
>>> Thus the Flags enum value for sig-poly remains constant even if the _intrinsic_id values do not (IIUC they will change when new intrinsics are added), thus less needs to be exposed to JVMCI.
>>
>> Yes, that’s what I was thinking. The intrinsic_id range seems more subject to change than a flag.
>
> Not at all. There are already manifest constants for that range. (Sorry I didn't point it out before.)
> They are named FIRST_MH_SIG_POLY and LAST_MH_SIG_POLY, both in vmIntrinsics::.
> Is it difficult to add them to vmStructs_jvmci.cpp?
No, that would be trivial.
However, since we’ve realized that this particular webrev is dealing with a context where there’s no Method* to query (for either intrinsic_id or a new flag), there’s no need to for it. If you want to expose a sig-poly test for ResolvedJavaMethod objects, then we’d need it.
-Doug
More information about the hotspot-compiler-dev
mailing list