[9] RFR (S): 8161720: Better byte behavior for off-heap data

[Zoltán Majó]

Hi Paul,


thank you for the feedback!

On 08/25/2016 08:00 PM, Paul Sandoz wrote:
>
>> On 25 Aug 2016, at 10:47, Zoltán Majó <zoltan.majo at oracle.com 
>> <mailto:zoltan.majo at oracle.com>> wrote:
>>
>> Here is the updated webrev (relative to Vladimir Ivanov's latest 
>> 8155635 and 8162101 changes):
>> - 
>> hotspot:http://cr.openjdk.java.net/~zmajo/8161720/webrev.02/hotspot/ 
>> <http://cr.openjdk.java.net/%7Ezmajo/8161720/webrev.02/hotspot/>
>> - jdk:http://cr.openjdk.java.net/~zmajo/8161720/webrev.02/jdk/ 
>> <http://cr.openjdk.java.net/%7Ezmajo/8161720/webrev.02/jdk/>
>>
>
> Thanks for updating Unsafe.byte2bool.
>
> I was gonna role that into another patch i have in my queue but you 
> beat me to it :-) (i am anyway blocked until something from hs-comp 
> roles into jdk9/dev.)
>
> Would you mind adding some comments to byte2bool and bool2byte saying 
> this is consistent with the behaviour in HotSpot e.g. that reads work 
> for T_BOOLEAN or JNI values, and writes normallize?

Sure. Please see the updated webrev in my response to John.

Thank you!

Best regards,


Zoltan

>
> Paul.