[9] RFR (S): 8161720: Better byte behavior for off-heap data

[Paul Sandoz]

> On 26 Aug 2016, at 06:54, Zoltán Majó <zoltan.majo at oracle.com> wrote:
> 
> Hi John,
> 
> 
> thank you for the feedback!
> 
> On 08/25/2016 10:25 PM, John Rose wrote:
>> On Aug 25, 2016, at 11:00 AM, Paul Sandoz <paul.sandoz at oracle.com <mailto:paul.sandoz at oracle.com>> wrote:
>>> 
>>> Would you mind adding some comments to byte2bool and bool2byte
>>> saying this is consistent with the behaviour in HotSpot e.g. that reads
>>> work for T_BOOLEAN or JNI values, and writes normallize?
>> 
>> +1
> 
> I added the documentation you and Paul have requested. I included some of the text on conversion conventions from your previous email. I hope that's fine.
> 
> Here is the updated webrev (I've changed only the jdk code relative to the previous webrev):
> http://cr.openjdk.java.net/~zmajo/8161720/webrev.03/jdk/
> 

+1

1604      * The JVM converts ints to booleans using two different

Perhaps change “ints to booleans” to “integral values to boolean values…”?

Thanks,
Paul.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160827/a7fe0857/signature.asc>