[9] RFR (S): 8161720: Better byte behavior for off-heap data

Paul Sandoz paul.sandoz at oracle.com
Mon Aug 29 15:57:27 UTC 2016


> On 29 Aug 2016, at 03:33, Zoltán Majó <zoltan.majo at oracle.com> wrote:
> 
> Hi Paul,
> 
> 
> thank you for the feedback!
> 
> On 08/27/2016 04:48 PM, Paul Sandoz wrote:
>>> On 26 Aug 2016, at 06:54, Zoltán Majó <zoltan.majo at oracle.com> wrote:
>>> [...]
>>> Here is the updated webrev (I've changed only the jdk code relative to the previous webrev):
>>> http://cr.openjdk.java.net/~zmajo/8161720/webrev.03/jdk/
>>> 
>> +1
>> 
>> 1604      * The JVM converts ints to booleans using two different
>> 
>> Perhaps change “ints to booleans” to “integral values to boolean values…”?
> 
> Sure, I just did that. Here is the updated webrev:
> 
> http://cr.openjdk.java.net/~zmajo/8161720/webrev.04/jdk/
> 

+1

Paul.

> FTR: I plan to push the latest webrev (webrev.04) on Tuesday, Aug 30, unless, of course, there are more suggestions on how to improve the code.
> 
> Thank you!
> 
> Best regards,
> 
> 
> Zoltan
> 
>> 
>> Thanks,
>> Paul.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160829/d9fd2295/signature.asc>


More information about the hotspot-compiler-dev mailing list