RFR(XS): 8149076: [JVMCI] missing ResourceMark in JVMCIRuntime::initialize_HotSpotJVMCIRuntime

Tom Rodriguez tom.rodriguez at oracle.com
Fri Feb 5 16:59:23 UTC 2016


Thanks!

tom

> On Feb 5, 2016, at 8:30 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> Looks good to me too.
> Thanks.
>> On Feb 5, 2016, at 7:27 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>> 
>> Looks good.  Igor, could you review the test changes?
>> 
>>> On Feb 4, 2016, at 5:57 PM, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8149076
>>> http://cr.openjdk.java.net/~never/8149076/webrev/
>>> 
>>> There's no explicit ResourceMark in JVMCIRuntime::initialize_HotSpotJVMCIRuntime but generally callers have one that it can use. However calling JVMCI.getRuntime() from a newly created thread will assert because there doesn't happen to be a containing resource mark. It should just have it's own.  I also modified to catch this case JVM_GetJVMCIRuntimeTest test to catch this case which required removing the unnecessary use of reflection, since this also introduced a containing ResourceMark that made the problem disappear.  Tested with test case.
>>> 
>>> tom
>> 
> 



More information about the hotspot-compiler-dev mailing list