[9]RFR(XS): 8149135: [jittester] Makefile copies JitTesterDriver in incorrect directory and always uses default value for number-of-tests and seed

Tatiana Pivovarova tatiana.pivovarova at oracle.com
Fri Feb 5 18:17:19 UTC 2016


Igor, thanks for your review!

I changed code accordingly your comment.
Here is updated version 
http://cr.openjdk.java.net/~tpivovarova/8149135/webrev.03

Tatiana

On 02/05/2016 09:08 PM, Igor Ignatyev wrote:
> Hi Tatiana,
>
> one minor nit : a space before before = is missed at line #38
>>    38 APPLICATION_ARGS=
> otherwise, looks good to me
>
> Thanks,
> Igor
>
>> On Feb 5, 2016, at 9:02 PM, Tatiana Pivovarova <tatiana.pivovarova at oracle.com> wrote:
>>
>> Hello!
>>
>> Please review the following patch for jit-tester.
>>
>> Makefile copies only jtreg/JitTesterDriver.java in <testbase-dir> instead full path jdk/test/lib/jittester/jtreg/JitTesterDriver.java
>> and don't read 'number-of-tests' and 'seed' parameters from the command line arguments.
>>
>> bug-id: https://bugs.openjdk.java.net/browse/JDK-8149135
>> webrew: http://cr.openjdk.java.net/~tpivovarova/8149135/webrev.01/index.html
>>
>> Thanks,
>> Tatiana

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160205/2c533c75/attachment.html>


More information about the hotspot-compiler-dev mailing list