RFR (M): 8149415: [AArch64] implement JVMCI CodeInstaller
Christian Thalinger
christian.thalinger at oracle.com
Thu Feb 11 00:34:17 UTC 2016
Damn. A last-minute change broke the build:
http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/diff/b038c3bea5a4/src/cpu/aarch64/vm/jvmciCodeInstaller_aarch64.cpp#l1.61 <http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/diff/b038c3bea5a4/src/cpu/aarch64/vm/jvmciCodeInstaller_aarch64.cpp#l1.61>
But since JPRT doesn’t build open AArch64 we didn’t catch it. Maybe we should pass the thread to CodeInstaller::pd_patch_DataSectionReference as well to have the option to throw an exception. I will send a review tomorrow. Sorry for the inconvenience.
> On Feb 10, 2016, at 9:58 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>
>
>> On Feb 10, 2016, at 8:54 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>> Why you need #ifdef _LP64 in jvmciCodeInstaller_aarch64.cpp? It is only 64 bit VM.
>
> Haha, yeah, good point. Copy-paste :-) I’ll remove it.
>
>> Otherwise looks good.
>>
>> Thanks,
>> Vladimir
>>
>> On 2/9/16 2:39 PM, Christian Thalinger wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8149415
>>> http://cr.openjdk.java.net/~twisti/8149415/webrev.01/
>>>
>>> This is a first cut of the CodeInstaller implementation for AArch64. One missing part is compressed oops support but
>>> it’s not a big issue because Graal doesn’t support it yet either.
>>>
>>> The patch also includes changes to AMD64 and SPARC’s RegisterConfig to use an array for the reserved registers. The
>>> code before was too hard to understand.
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160210/9c91fde6/attachment.html>
More information about the hotspot-compiler-dev
mailing list