[9] RFR 8149472: NPE when executing HotSpotConstantReflectionProvider::constantEquals with null first arg

Konstantin Shefov konstantin.shefov at oracle.com
Thu Feb 11 06:41:10 UTC 2016


Doug, Christian, Vladimir, thank you for reviewing.

Here is a patch with space:
http://cr.openjdk.java.net/~kshefov/8149472/webrev.01/

-Konstantin

10.02.2016 23:02, Christian Thalinger пишет:
> +            return Objects.equals(x,y);
>
> There is a missing space.  Are you using an IDE?
>
>> On Feb 10, 2016, at 1:20 AM, Konstantin Shefov 
>> <konstantin.shefov at oracle.com <mailto:konstantin.shefov at oracle.com>> 
>> wrote:
>>
>> Hello
>>
>> Please review a bug fix in JVMCI 
>> jdk.vm.ci.hotspot.HotSpotConstantReflectionProvider::constantEquals(Constant 
>> x, Constant y) method.
>>
>> A NullPointerException is thrown, when one calls this method with the 
>> first argument x equal to null.
>>
>> Additional check should be added for null as the first argument.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8149472
>> Webrev: http://cr.openjdk.java.net/~kshefov/8149472/webrev.00/
>>
>> Thanks
>> -Konstantin
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160211/65504b57/attachment.html>


More information about the hotspot-compiler-dev mailing list