FW: RFR(XXS): 8149488: Incorrect declaration of bitsInByte in regmask.cpp

[Berg, Michael C]

Should we not extend:

This does not match the actual definition in share/vm/libadt/vectset.cpp: 
 uint8_t bitsInByte[256] = { // ...

to 512

-----Original Message-----
From: Berg, Michael C 
Sent: Thursday, February 11, 2016 9:57 AM
To: 'Vladimir Ivanov'
Subject: RE: RFR(XXS): 8149488: Incorrect declaration of bitsInByte in regmask.cpp

So how do we intend to map a VecZ register without 512 bits?

-Michael

-----Original Message-----
From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Ivanov
Sent: Thursday, February 11, 2016 4:54 AM
To: Rahul Raghavan; hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR(XXS): 8149488: Incorrect declaration of bitsInByte in regmask.cpp

Rahul,

Can we define a constant instead and use it in both places?

Best regards,
Vladimir Ivanov

On 2/11/16 10:42 AM, Rahul Raghavan wrote:
> Hi,
>
> Please review the patch for JDK- 8149488.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8149488
> Webrev: http://cr.openjdk.java.net/~thartmann/8149488/webrev.00/
>
> Corrected the bitsInByte array size in declaration.
>
> Thanks,
> Rahul
>