RFR (S): 8149689: [JVMCI] CodeInstaller::pd_patch_DataSectionReference should be able to throw exceptions

[Vladimir Kozlov]

Got it. Good.

Thanks,
Vladimir

On 2/11/16 1:02 PM, Christian Thalinger wrote:
>
>> On Feb 11, 2016, at 10:48 AM, Vladimir Kozlov
>> <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote:
>>
>> So what is the fix for if this method can't throw exceptions?
>> There is no explanation what is going on and what the problem you have.
>
> Oh, sorry, it’s in the review thread of 8149415.  I broke open AArch64
> builds because I made it throw an exception:
>
> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/b038c3bea5a4#l1.61
>
> We should be able to throw exceptions in all these methods because we
> don’t want JVMCI to bring down the whole VM if something goes wrong
> during code installation.
>
>>
>> Thanks,
>> Vladimir
>>
>> On 2/11/16 9:56 AM, Christian Thalinger wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8149689
>>> http://cr.openjdk.java.net/~twisti/8149689/webrev.01/
>>>
>>> All the other CodeInstaller::pd_patch_* methods can throw exceptions
>>> except this one.  This fixes the AArch64 issue I introduced with 8149415.
>>>
>