[9] RFR 8149472: NPE when executing HotSpotConstantReflectionProvider::constantEquals with null first arg

[Konstantin Shefov]

Christian,

Actually, in NetBeans by default one should press Alt+Shift+F to format 
the code. And I have forgotten to press it when I send the previous review.

-Konstantin

On 02/11/2016 10:52 PM, Christian Thalinger wrote:
> Looks good.  The IDE question still stands.  If you are using an IDE 
> this shouldn't have happened.
>
>> On Feb 10, 2016, at 8:41 PM, Konstantin Shefov 
>> <konstantin.shefov at oracle.com <mailto:konstantin.shefov at oracle.com>> 
>> wrote:
>>
>> Doug, Christian, Vladimir, thank you for reviewing.
>>
>> Here is a patch with space:
>> http://cr.openjdk.java.net/~kshefov/8149472/webrev.01/
>>
>> -Konstantin
>>
>> 10.02.2016 23:02, Christian Thalinger пишет:
>>> +            return Objects.equals(x,y);
>>>
>>> There is a missing space.  Are you using an IDE?
>>>
>>>> On Feb 10, 2016, at 1:20 AM, Konstantin Shefov 
>>>> <konstantin.shefov at oracle.com 
>>>> <mailto:konstantin.shefov at oracle.com>> wrote:
>>>>
>>>> Hello
>>>>
>>>> Please review a bug fix in JVMCI 
>>>> jdk.vm.ci.hotspot.HotSpotConstantReflectionProvider::constantEquals(Constant 
>>>> x, Constant y) method.
>>>>
>>>> A NullPointerException is thrown, when one calls this method with 
>>>> the first argument x equal to null.
>>>>
>>>> Additional check should be added for null as the first argument.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8149472
>>>> Webrev: http://cr.openjdk.java.net/~kshefov/8149472/webrev.00/
>>>>
>>>> Thanks
>>>> -Konstantin
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160212/3569c24c/attachment.html>