RFR(L) 8149655: PPC64: Implement CompactString intrinsics

[Doerr, Martin]

Hi Vladimir,

thanks for taking a look.

We are using multi-lines and comments in effects for many years and have never seen any problems.
I have also taken a look at the generated files and didn't find any errors.
Seems like ADLC works better than one might think :-)

The $archOpcode statements are for our Power6 scheduler which we haven't contributed, yet.
I guess we will remove these comments later if we decide not to contribute it.

Best regards,
 Martin


-----Original Message-----
From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com] 
Sent: Freitag, 12. Februar 2016 02:03
To: Doerr, Martin <martin.doerr at sap.com>; hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR(L) 8149655: PPC64: Implement CompactString intrinsics

This needs review from ppc64 experts.

Are you sure ADLC supports multilines and comments in effect():?

+  effect(USE_KILL haycnt, /* better: TDEF haycnt, */ TEMP_DEF result,
+         TEMP tmp1, TEMP tmp2, TEMP tmp3, TEMP tmp4, TEMP tmp5, KILL 
cr0, KILL cr1, KILL cr6, KILL ctr);

What next repetitive comment means?

// TODO: PPC port $archOpcode(ppc64Opcode_compound);

Thanks,
Vladimir

On 2/11/16 7:11 AM, Doerr, Martin wrote:
> Hi,
>
> I have created a webrev which adds the following String intrinsics to PPC64:
>
> 0 string_compareL
>
> 1 string_compareU
>
> 2 string_compareLU
>
> 3 string_compareUL
>
> 4 string_equalsL
>
> 5 string_equalsU
>
> 6 array_equalsB
>
> 7 array_equalsC
>
> 8 indexOf_imm1_char_U
>
> 9 indexOf_imm1_char_L
>
> 10 indexOf_imm1_char_UL
>
> 11 indexOf_imm1_U
>
> 12 indexOf_imm1_L
>
> 13 indexOf_imm1_UL
>
> 14 indexOfChar_U
>
> 15 indexOf_imm_U
>
> 16 indexOf_imm_L
>
> 17 indexOf_imm_UL
>
> 18 indexOf_U
>
> 19 indexOf_L
>
> 20 indexOf_UL
>
> 21 string_compress
>
> 22 string_inflate
>
> 23 has_negatives
>
> 24 encode_iso_array
>
> It also contains some other minor improvements.
>
> The webrev is here:
>
> http://cr.openjdk.java.net/~mdoerr/8149655_PPC64_StringIntrinsics/webrev.00/
>
> Please review.
>
> I will also need a sponsor from Oracle because the change touches one
> java test file (test/compiler/intrinsics/string/TestStringIntrinsics2.java).
>
> Best regards,
>
> Martin
>