RFR(s): AAch64: Adding byte array equal support

Hui Shi hui.shi at linaro.org
Fri Feb 12 11:10:07 UTC 2016


Hi Andrew,
   Are you suggesting we should refactoring these similar code to make them
share most part? Similar with handling different array copies?

Regards
Hui

On 10 February 2016 at 23:41, Andrew Haley <aph at redhat.com> wrote:

> On 02/07/2016 10:35 AM, Andrew Haley wrote:
> > On 06/02/16 12:24, Hui Shi wrote:
> >> Hi All,
> >>
> >> Would someone help review this patch for adding byte array equal
> support on
> >> aarch64?
> >>
> >> bug: https://bugs.openjdk.java.net/browse/JDK-8149100
> >> webrev: http://cr.openjdk.java.net/~hshi/8149100/webrev/
> >
> > Ok, thanks.
>
> Having said that, I'm unhappy that this code is almost exactly the same
> as char_arrays_equals, seeming to have a slab of identical code.  We've
> also got char_arrays_equals, which seems to do the same thing as
> string_equals.
>
> Andrew.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160212/f0053a3f/attachment.html>


More information about the hotspot-compiler-dev mailing list