RFR(s): AAch64: Adding byte array equal support
Hui Shi
hui.shi at linaro.org
Fri Feb 12 11:21:39 UTC 2016
You're right! Checking X86 implementation it use same arrays_equals
implementation for all these operations, we can do this for AArch64 too.
I'll create a new work item and follow up with this.
Regards
Hui
On 12 February 2016 at 19:18, Andrew Haley <aph at redhat.com> wrote:
> On 12/02/16 11:10, Hui Shi wrote:
> > Are you suggesting we should refactoring these similar code to make
> them
> > share most part? Similar with handling different array copies?
>
> Yes, absolutely. There are almost no code differences.
>
> Code duplication of this kind has what we call a "bad smell". It is
> not necessarily wrong, and there may be a good reason for it, but it
> is always suspicious.
>
> Andrew.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160212/59e028cc/attachment.html>
More information about the hotspot-compiler-dev
mailing list