[9] RFR 8149472: NPE when executing HotSpotConstantReflectionProvider::constantEquals with null first arg

[Christian Thalinger]

I forgot to mention that I pushed a missing file yesterday:

http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/a43579055b3c <http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/a43579055b3c>

Now “mx checkstyle” actually works and would tell you about this:

$ mx checkstyle
Running Checkstyle on /Users/cthaling/ws/jdk9/hs-comp/hotspot/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src using /Users/cthaling/ws/jdk9/hs-comp/hotspot/src/jdk.vm.ci/share/classes/jdk.vm.ci.services/.checkstyle_checks.xml...
Checkstyle ends with 1 errors.
/Users/cthaling/ws/jdk9/hs-comp/hotspot/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantReflectionProvider.java:74: ',' is not followed by whitespace.

> On Feb 12, 2016, at 6:46 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
> There are no on-save actions as in Eclipse?  Too bad.
> 
>> On Feb 11, 2016, at 11:45 PM, Konstantin Shefov <konstantin.shefov at oracle.com <mailto:konstantin.shefov at oracle.com>> wrote:
>> 
>> Christian,
>> 
>> Actually, in NetBeans by default one should press Alt+Shift+F to format the code. And I have forgotten to press it when I send the previous review.
>> 
>> -Konstantin
>> 
>> On 02/11/2016 10:52 PM, Christian Thalinger wrote:
>>> Looks good.  The IDE question still stands.  If you are using an IDE this shouldn't have happened.
>>> 
>>>> On Feb 10, 2016, at 8:41 PM, Konstantin Shefov <konstantin.shefov at oracle.com <mailto:konstantin.shefov at oracle.com>> wrote:
>>>> 
>>>> Doug, Christian, Vladimir, thank you for reviewing.
>>>> 
>>>> Here is a patch with space:
>>>> http://cr.openjdk.java.net/~kshefov/8149472/webrev.01/ <http://cr.openjdk.java.net/%7Ekshefov/8149472/webrev.01/>
>>>> 
>>>> -Konstantin
>>>> 
>>>> 10.02.2016 23:02, Christian Thalinger пишет:
>>>>> +            return Objects.equals(x,y);
>>>>> 
>>>>> There is a missing space.  Are you using an IDE?
>>>>> 
>>>>>> On Feb 10, 2016, at 1:20 AM, Konstantin Shefov < <mailto:konstantin.shefov at oracle.com>konstantin.shefov at oracle.com <mailto:konstantin.shefov at oracle.com>> wrote:
>>>>>> 
>>>>>> Hello
>>>>>> 
>>>>>> Please review a bug fix in JVMCI jdk.vm.ci.hotspot.HotSpotConstantReflectionProvider::constantEquals(Constant x, Constant y) method. 
>>>>>> 
>>>>>> A NullPointerException is thrown, when one calls this method with the first argument x equal to null. 
>>>>>> 
>>>>>> Additional check should be added for null as the first argument.
>>>>>> 
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8149472 <https://bugs.openjdk.java.net/browse/JDK-8149472> 
>>>>>> Webrev: http://cr.openjdk.java.net/~kshefov/8149472/webrev.00/ <http://cr.openjdk.java.net/%7Ekshefov/8149472/webrev.00/>
>>>>>> 
>>>>>> Thanks
>>>>>> -Konstantin
>>>>>> 
>>>>> 
>>>> 
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160212/bc5b3fed/attachment-0001.html>