[9] RFR (M): 8149741: Don't refer to stub entry points by index in external_word relocations

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Fri Feb 19 10:30:55 UTC 2016


Thanks, Vladimir.

Best regards,
Vladimir Ivanov

On 2/18/16 11:10 PM, Vladimir Kozlov wrote:
> Looks good.
>
> thanks,
> Vladimir
>
> On 2/18/16 12:43 AM, Vladimir Ivanov wrote:
>>> Nice clean up!
>> Thanks, Vladimir.
>>
>> Updated webrev:
>>    http://cr.openjdk.java.net/~vlivanov/8149741/webrev.01.index/
>>
>>>
>>> Casts should be the same:
>>>
>>> (uintptr_t)target >= (uint)os::vm_page_size()
>> Fixed.
>>
>>> Why in assembler_windows_x86.cpp you used NULL_WORD and not simple NULL?
>>> NULL_WORD is used for integer values and NULL for pointers
>>> which is this case.
>> Fixed.
>>
>> Best regards,
>> Vladimir Ivanov


More information about the hotspot-compiler-dev mailing list