[9] RFR JDK-8141619: Develop new tests for JVMCI compilerToVM class' CP related methods

[Konstantin Shefov]

Chris,

I have added some imports to get rid of long names.
http://cr.openjdk.java.net/~kshefov/8141619/webrev.02/

-Konstantin

On 02/18/2016 09:56 PM, Christian Thalinger wrote:
>   57 typeTests.put(ConstantPoolTestCase.ConstantTypes.CONSTANT_METHODREF,
>   58 LookupNameAndTypeRefIndexInPoolTest::validate);
>
> You should use static imports so you can get rid 
> of ConstantPoolTestCase.ConstantTypes.  Actually, the same would be 
> useful in your other review too.
>
>> On Feb 18, 2016, at 12:44 AM, Konstantin Shefov 
>> <konstantin.shefov at oracle.com <mailto:konstantin.shefov at oracle.com>> 
>> wrote:
>>
>> According to Christian's comments to RFR JDK-8141618 I have 
>> reformatted the code to make it look better:
>> http://cr.openjdk.java.net/~kshefov/8141619/webrev.01/
>>
>> -Konstantin
>>
>> On 02/17/2016 09:46 PM, Christian Thalinger wrote:
>>>
>>>> On Feb 17, 2016, at 4:00 AM, Konstantin Shefov 
>>>> <konstantin.shefov at oracle.com 
>>>> <mailto:konstantin.shefov at oracle.com>> wrote:
>>>>
>>>> Hello
>>>>
>>>> Please review new tests for methods of JVMCI 
>>>> jdk.vm.ci.hotspot.CompilerToVM class.
>>>>
>>>> See https://bugs.openjdk.java.net/browse/JDK-8138708 for more info.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8141619
>>>> Webrev: http://cr.openjdk.java.net/~kshefov/8141619/webrev.00/ 
>>>> <http://cr.openjdk.java.net/%7Ekshefov/8141619/webrev.00/>
>>>
>>> Link is wrong: http://cr.openjdk.java.net/~kshefov/8141619/webrev/ 
>>> <http://cr.openjdk.java.net/%7Ekshefov/8141619/webrev/>
>>>
>>>>
>>>> Thanks
>>>> -Konstantin
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160219/e5e66e03/attachment-0001.html>