[9] RFR JDK-8141618: Change JVMCI compilerToVM constant pool tests to support CP caching

[Christian Thalinger]

Much better.  Looks good.

> On Feb 19, 2016, at 4:27 AM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
> 
> Chris,
> 
> I have added some imports to get rid of long names.
> http://cr.openjdk.java.net/~kshefov/8141618/webrev.02/
> 
> -Konstantin
> 
> On 02/18/2016 09:52 PM, Christian Thalinger wrote:
>> It’s difficult to follow the logic and make sure there is no bug.  I did not verify all this.  Looks good anyway.
>> 
>>> On Feb 18, 2016, at 12:43 AM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
>>> 
>>> Christian, thanks for looking into this
>>> 
>>> I have reformatted the code to make it look better:
>>> http://cr.openjdk.java.net/~kshefov/8141618/webrev.01
>>> 
>>> -Konstantin
>>> 
>>> On 02/17/2016 09:43 PM, Christian Thalinger wrote:
>>>> Why do you have to break every line at, what, 50 characters?  This is unreadable:
>>>> 
>>>> +        TAG_TO_TYPE_MAP.put(ConstantPool.Tag.CLASS,
>>>> +                ConstantTypes.CONSTANT_CLASS);
>>>> +        TAG_TO_TYPE_MAP.put(ConstantPool.Tag.FIELDREF,
>>>> +                ConstantTypes.CONSTANT_FIELDREF);
>>>> +        TAG_TO_TYPE_MAP.put(ConstantPool.Tag.METHODREF,
>>>> +                ConstantTypes.CONSTANT_METHODREF);
>>>> +        TAG_TO_TYPE_MAP.put(ConstantPool.Tag.INTERFACEMETHODREF,
>>>> +                ConstantTypes.CONSTANT_INTERFACEMETHODREF);
>>>> +        TAG_TO_TYPE_MAP.put(ConstantPool.Tag.STRING,
>>>> +                ConstantTypes.CONSTANT_STRING);
>>>> +        TAG_TO_TYPE_MAP.put(ConstantPool.Tag.INTEGER,
>>>> +                ConstantTypes.CONSTANT_INTEGER);
>>>> +        TAG_TO_TYPE_MAP.put(ConstantPool.Tag.FLOAT,
>>>> +                ConstantTypes.CONSTANT_FLOAT);
>>>> +        TAG_TO_TYPE_MAP.put(ConstantPool.Tag.LONG,
>>>> +                ConstantTypes.CONSTANT_LONG);
>>>> +        TAG_TO_TYPE_MAP.put(ConstantPool.Tag.DOUBLE,
>>>> 
>>>> And this is not the only occurrence.  I can’t review this.
>>>> 
>>>>> On Feb 17, 2016, at 3:57 AM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
>>>>> 
>>>>> Hello
>>>>> 
>>>>> Please review a test enhancement.
>>>>> It is an improvement for JVMCI CompilerToVM class tests.
>>>>> 
>>>>> See https://bugs.openjdk.java.net/browse/JDK-8138708 for more info.
>>>>> 
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8141618
>>>>> Webrev: http://cr.openjdk.java.net/~kshefov/8141618/webrev.00/
>>>>> 
>>>>> Thanks
>>>>> -Konstantin
>