RFR (S): 8148563: compiler/compilercontrol/jcmd/StressAddMultiThreadedTest.java timesout
Vladimir Kozlov
vladimir.kozlov at oracle.com
Fri Feb 19 20:45:46 UTC 2016
Seems fine. What size of directive files was before and after this fix?
JBS does not have this information.
Thanks,
Vladimir
On 2/19/16 9:04 AM, Pavel Punegov wrote:
> Hi,
>
> please review the fix for a test bug.
>
> Issue:
> 1. Test timeouts because it executes a lot of jcmd processes. Number of
> threads is calculated as number of processors (cores) * 10, that led to
> an enormous number of jcmds executed on hosts with lots of CPUs/cores.
> 2. Test also spends a lot of time to generate 5 huge directive files,
> that were tried to be added on to the directives stack. Directive stack
> has a limit (default 50, controlled by CompilerDirectivesLimit).
>
> Fix:
> 1. Calculate number of threads as a log of the number of CPUs/cores * 10.
> 2. Generate only one file that is less than specified
> CompilerDirectivesLimit.
> 3. Add different commands to execute (add, clear, remove and print) and
> generate them on demand.
>
> webrev: http://cr.openjdk.java.net/~ppunegov/8148563/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8148563
>
> — Pavel.
>
More information about the hotspot-compiler-dev
mailing list