RFR(S): 8148159: [TESTBUG] TestCompilerDirectivesCompatibility tests fails on non-tiered server VMs

[Nils Eliasson]

Hi Pavel,

On 2016-02-17 16:52, Pavel Punegov wrote:
> Hi Nils,
>
> Do we need hasC1/2Compiler methods? 

I wanted to know exactly what compilers I am testing.

> There is a compiler.tstlibrary.CompilerUtils class that provides tests 
> with available levels. 

Didn't know about that one. It fills a good purpose but it should not 
guess what compiler levels are available - rather query the VM directly. 
We should also move a lot of useful constants from CompilerWhiteBoxTest 
to CompilerUtils.

> There is an example of usage 
> in test/compiler/compilercontrol/share/actions/CompileAction.java.
> Also, what about JVMCI in case of hasC2Compiler? AFAIK it works with 
> levels, but I don’t know if it will with such ifdef.

I only test the compilers that I know will support this flag. We would 
need some additional test utils for querying what compiler uses the 
JVMCI interface.

>
> Otherwise, it looks good (not a Reviewer)

Thanks for taking a look,
Nils

>
>> On 16 Feb 2016, at 16:01, Nils Eliasson <nils.eliasson at oracle.com 
>> <mailto:nils.eliasson at oracle.com>> wrote:
>>
>> Hi,
>>
>> Please review this change.
>>
>> The tests relied on C1 always being available and thus fails on C2 
>> only server configurations. The fix adds two whitebox methods for 
>> checking if C1 and C2 is available, and then tests both compilers 
>> separately. Also adding Xmixed to the commandline since this test 
>> doesn't need Xcomp testing.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8148159
>>
>> Webrev:
>> http://cr.openjdk.java.net/~neliasso/8148159/webrev.01/
>> http://cr.openjdk.java.net/~neliasso/8148159/webrev_jdk.01/
>>
>> Regards,
>> Nils Eliasson
>
>
>
> — Thanks,
> Pavel Punegov
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160222/5a9c5468/attachment.html>