RFR(S): 8148159: [TESTBUG] TestCompilerDirectivesCompatibility tests fails on non-tiered server VMs

[Nils Eliasson]

On second thought - I'll import the constants from CompilerWhiteBox and 
then we can discuss what we want to do with CompilerUtils and 
CompilerWhiteBox in the future.

Webrev: http://cr.openjdk.java.net/~neliasso/8148159/webrev.03/
JDK Webrev: http://cr.openjdk.java.net/~neliasso/8148159/webrev_jdk.02/ 
(Not changed)

Best regards,
Nils Eliasson

On 2016-02-24 09:57, Nils Eliasson wrote:
> Hi Vladimir,
>
> CompilerWhiteBoxTest.java includes a lot of other unrelated things 
> too. I suggest to put all the common constants in CompilerUtils and 
> import that one into CompilerWhiteBox.
>
> Regards,
> Nils
>
> On 2016-02-23 23:41, Vladimir Kozlov wrote:
>> COMP_LEVEL_* is mess. I see a several tests which are repeating their 
>> definitions.
>> I think we should use the same values already defined in 
>> test/compiler/whitebox/CompilerWhiteBoxTest.java
>>
>> Thanks,
>> Vladimir
>>
>> On 2/22/16 2:37 AM, Nils Eliasson wrote:
>>> Hi,
>>>
>>> Webrev using comp levels from CompilerUtils instead:
>>>
>>> http://cr.openjdk.java.net/~neliasso/8148159/webrev.02/
>>> http://cr.openjdk.java.net/~neliasso/8148159/webrev_jdk.02/
>>>
>>> Best regards,
>>> Nils Eliasson
>>>
>>> On 2016-02-22 10:47, Nils Eliasson wrote:
>>>> Hi Pavel,
>>>>
>>>> On 2016-02-17 16:52, Pavel Punegov wrote:
>>>>> Hi Nils,
>>>>>
>>>>> Do we need hasC1/2Compiler methods?
>>>>
>>>> I wanted to know exactly what compilers I am testing.
>>>>
>>>>> There is a compiler.tstlibrary.CompilerUtils class that provides 
>>>>> tests with available levels.
>>>>
>>>> Didn't know about that one. It fills a good purpose but it should 
>>>> not guess what compiler levels are available -
>>>> rather query the VM directly. We should also move a lot of useful 
>>>> constants from CompilerWhiteBoxTest to CompilerUtils.
>>>>
>>>>> There is an example of usage in 
>>>>> test/compiler/compilercontrol/share/actions/CompileAction.java.
>>>>> Also, what about JVMCI in case of hasC2Compiler? AFAIK it works 
>>>>> with levels, but I don’t know if it will with such ifdef.
>>>>
>>>> I only test the compilers that I know will support this flag. We 
>>>> would need some additional test utils for querying
>>>> what compiler uses the JVMCI interface.
>>>>
>>>>>
>>>>> Otherwise, it looks good (not a Reviewer)
>>>>
>>>> Thanks for taking a look,
>>>> Nils
>>>>
>>>>>
>>>>>> On 16 Feb 2016, at 16:01, Nils Eliasson <nils.eliasson at oracle.com 
>>>>>> <mailto:nils.eliasson at oracle.com>> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please review this change.
>>>>>>
>>>>>> The tests relied on C1 always being available and thus fails on 
>>>>>> C2 only server configurations. The fix adds two
>>>>>> whitebox methods for checking if C1 and C2 is available, and then 
>>>>>> tests both compilers separately. Also adding
>>>>>> Xmixed to the commandline since this test doesn't need Xcomp 
>>>>>> testing.
>>>>>>
>>>>>> Bug:
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8148159
>>>>>>
>>>>>> Webrev:
>>>>>> http://cr.openjdk.java.net/~neliasso/8148159/webrev.01/
>>>>>> http://cr.openjdk.java.net/~neliasso/8148159/webrev_jdk.01/
>>>>>>
>>>>>> Regards,
>>>>>> Nils Eliasson
>>>>>
>>>>>
>>>>>
>>>>> — Thanks,
>>>>> Pavel Punegov
>>>>>
>>>>
>>>
>