[9] RFR (S): 8150349: Reduce the execution time of the hotspot_compiler_3 group

[Zoltán Majó]

Hi,


I think all issues that were brought up with this fix were address, so 
I'll push the fix shortly.

Thank you, Vladimir and Nils, for the review!

Best regards,


Zoltan


On 02/26/2016 07:27 PM, Vladimir Kozlov wrote:
> Good. I am fine to not split test group since, as you pointed, we will 
> work on tests time improvement.
>
> Thanks,
> Vladimir
>
> On 2/26/16 4:29 AM, Zoltán Majó wrote:
>> Hi Vladimir,
>>
>>
>> On 02/25/2016 06:21 PM, Vladimir Kozlov wrote:
>>> I am fine with removal of adler32 and bmi testing from JPRT runs
>>> because we don't have a plan to touch them.
>>> But code related to CRC32, CRC32c and string may be touched soon for
>>> some platforms.
>>
>> OK, so I've re-enabled testing of the CRC23, CRC32c and string
>> intrinsics (still within the hotspot_compiler_3 group). Running the
>> group still takes < 30 minutes on our slowest platforms, here are the
>> execution times:
>>
>> West:
>>   linux_arm64_2.6-fastdebug-c2-hotspot_compiler_3 success(25m 12s)
>>   solaris_sparcv9_5.11-fastdebug-c2-hotspot_compiler_3 success(11m 46s)
>>
>> Stockholm:
>>    linux_arm64_2.6-fastdebug-c2-hotspot_compiler_3 success(24m 18s)
>>    solaris_sparcv9_5.11-fastdebug-c2-hotspot_compiler_3 success(21m 01s)
>>
>> Here is the updated webrev:
>> http://cr.openjdk.java.net/~zmajo/8150349/webrev.01/
>>
>>> What if we created hotspot_compiler_4 group for them? How much time it
>>> would take to run it on slow platforms?
>>
>> I think it's fine to leave all tests in hotspot_compiler_3 as all
>> execution times are still below 30 minutes.
>>
>> I filed INTJDK-7622854: "Track the execution time of JPRT tests groups"
>> so that we can better track the execution times of the
>> hotspot_compiler_[1-3] test groups.
>>
>> Thank you!
>>
>> Best regards,
>>
>>
>> Zoltan
>>
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 2/25/16 8:12 AM, Zoltán Majó wrote:
>>>> Hi Nils,
>>>>
>>>>
>>>> thank you for the feedback!
>>>>
>>>> On 02/25/2016 04:22 PM, Nils Eliasson wrote:
>>>>> Hi Zoltan,
>>>>>
>>>>> Have you opened a bug for fixing the tests?
>>>>
>>>> No, I have not, because there is an existing issue (INTJDK-7620326)
>>>> that is supposed to take care of the high execution
>>>> time of intrinsic-related tests on platforms where the relevant
>>>> intrinsics are not available. I've linked the two issues.
>>>>
>>>>>
>>>>> Do we really want to remove the String intrinsics from the list?
>>>>> aren't they pretty new?
>>>>
>>>> You are right, they are in part new (in part old intrinsics have been
>>>> updated). I thought to remove them nevertheless,
>>>> because they take a long time to execute and are anyway executed in
>>>> our nightlies.
>>>>
>>>> Best regards,
>>>>
>>>>
>>>> Zoltan
>>>>
>>>>>
>>>>> Thanks for fixing this,
>>>>> Nils Eliasson
>>>>>
>>>>> On 2016-02-25 15:17, Zoltán Majó wrote:
>>>>>> Hi,
>>>>>>
>>>>>>
>>>>>> please review the patch for 8150349.
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8150349
>>>>>>
>>>>>> Problem: The hotspot_compiler_3 group of tests takes more than 30
>>>>>> minutes on our slowest platforms.
>>>>>>
>>>>>>
>>>>>> Solution: Remove a number of long-running tests from the
>>>>>> hotspot_compiler_3 group. All removed tests are related to
>>>>>> intrinsics, that is, they check the functionality of a reduced set
>>>>>> of the VM's functionality that is not often
>>>>>> modified. Also, we execute all removed tests daily (in our nightly
>>>>>> testing).
>>>>>>
>>>>>> Here is the time spent in hotspot_compiler_3 on our slowest
>>>>>> platforms after removing the tests:
>>>>>>
>>>>>> West:
>>>>>> solaris_sparcv9_5.11-fastdebug-c2-hotspot_compiler_3 success(15m 
>>>>>> 22s)
>>>>>>     platform=solaris_sparc_5.11 osname=solaris osarch=sparc cpus=6
>>>>>> parallelcount=6 ram=31744MB cpufreqmhz=2848
>>>>>> linux_arm64_2.6-fastdebug-c2-hotspot_compiler_3 success(19m 09s)
>>>>>>     platform=linux_x64_3.8 osname=linux osarch=x64 cpus=12
>>>>>> parallelcount=12 ram=60690MB cpufreqmhz=2294
>>>>>>
>>>>>> Stockholm:
>>>>>> solaris_sparcv9_5.11-fastdebug-c2-hotspot_compiler_3 success(15m 
>>>>>> 32s)
>>>>>>     platform=solaris_sparc_5.11 osname=solaris osarch=sparc cpus=12
>>>>>> parallelcount=12 ram=24576MB    cpufreqmhz=2848
>>>>>> linux_arm64_2.6-fastdebug-c2-hotspot_compiler_3 success(20m 24s)
>>>>>>     platform=linux_arm64_3.13 osname=linux osarch=arm64 cpus=8
>>>>>> parallelcount=8 ram=16061MB
>>>>>>
>>>>>>
>>>>>> Webrev:
>>>>>> http://cr.openjdk.java.net/~zmajo/8150349/webrev.00/
>>>>>>
>>>>>> Thank you!
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>>
>>>>>> Zoltan
>>>>>>
>>>>>
>>>>
>>