[9] RFR (M): 8143407: C1: @Stable array support

[Vladimir Ivanov]

Chris,

>> I slightly reworded the assert message. Hope it reads better now:
>> +         assert(!field->is_stable() || !field_value.is_null_or_zero(),
>> +                "stable static w/ default value should not be a constant”);
>
> Better, thanks.  Are we saving bytes in assert messages now? ;-)
Well, more like keystrokes :-) But I can expand the message if you wish.

>>> +   switch (field_type) {
>>> +     case T_ARRAY:
>>> +     case T_OBJECT:
>>> +       if (field_value.as_object()->should_be_constant()) {
>>> +         return new Constant(value);
>>> +       }
>>> +       break;
>>> +     default:
>>> +      return new Constant(value);
>
> Just noticed the indent is wrong on this line.
Fixed.

Best regards,
Vladimir Ivanov