RFR (S) 8150669: C1 intrinsic for Class.isPrimitive

Claes Redestad claes.redestad at oracle.com
Mon Feb 29 14:28:26 UTC 2016


Hi,

On 2016-02-29 12:54, Aleksey Shipilev wrote:
> On 02/25/2016 11:56 PM, Aleksey Shipilev wrote:
>> I would like to amend C1 with handling Class.isPrimitive intrinsic:
>>    http://cr.openjdk.java.net/~shade/8150669/webrev.01/

I'm not intimate with the C1 code, but overall the changes and the
added test seems OK to me.

>>    https://bugs.openjdk.java.net/browse/JDK-8150669
>>
>> Through a long chain of dependencies, it would benefit String
>> concatenation, possibly startup (lots of usages in java.lang.invoke, and
>> who knows how many other places in JDK that use reflective meddling),
>> and also, for a fun of it, fastdebug builds.
>>
>> Performance data shows we improve all interesting cases:
>>    http://cr.openjdk.java.net/~shade/8150669/notes.txt

This looks really good!

Thanks!

/Claes

>>
>> Testing: new test; targeted benchmarks; JPRT -testset hotspot
> Also, RBT tests are passing:
>   hotspot/test/:hotspot_all,vm.runtime.testlist,vm.compiler.testlist
>
> Please review!
>
> -Aleksey
>



More information about the hotspot-compiler-dev mailing list